Changelog Digest for Tues, Feb 21

Feb. 21st, 2017 11:19 pm
kareila: (Default)
[personal profile] kareila posting in [community profile] changelog_digest

These are live on the site:

[dw-free]

4b4f745: Issue #1983: fix uploading of non-factory, non-URL icons
Fix one more occurrence of reference mismatch errors.
c172a10: Issue #1855: Save descriptions can give error message when there are no descriptions
Improve handling of media load errors on /file/edit.
7400b91: Issue #2003: additional headers for media file requests
Use the Cache-Control and Last-Modified headers for media file requests.

These are in the queue for the next code push:

[dw-free]

2c5a6d5: Issue #1986: Use of $# considered harmful
Use 'scalar' to get the correct count of items in the array.
eb9640e: Issue #1991: Post-push log cleanup
Fix undefined warning in DW/Controller/Feeds.pm.
29afdd4: Issue #1991: Post-push log cleanup
Fix undefined warning in DW/Controller/EditIcons.pm.
60d05ba: Issue #1991: Post-push log cleanup
Fix undefined warning in LJ/Userpic.pm.
b2ab126: Issue #1991: Post-push log cleanup
Avoid die statement in LJ/Poll.pm.
1b9abed: Issue #1991: Post-push log cleanup
Avoid calling method on undefined object in DW/Routing.pm.
ae9ef2c: Issue #1991: Post-push log cleanup
Fix undefined warning in DW/Controller/ChangeEmail.pm.
850cf4c: Issue #1991: Post-push log cleanup
Fix undefined warning in DW/Controller/API/Media.pm.
1fd3c0f: Issue #1991: Post-push log cleanup
Remove unused variable from DW::Routing.
1ded4d4: Issue #1992: entry loses slug on edit if poster and journal are on different clusters
Use correct user object when deleting existing slugs.
e69b60f: Issue #1988: remove null-op LJ/EventLogRecord.pm and submodules
Remove EventLogRecord.pm and submodules.
fd91296: Issue #1988: remove null-op LJ/EventLogRecord.pm and submodules
Fix postevent test failures caused by removing EventLogRecord.
4e9b78b: Issue #1988: remove null-op LJ/EventLogRecord.pm and submodules
Use another method to repopulate the entry object data.
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/release-1.32
Home: https://github.com/dreamwidth/dw-free
Commit: 941441147bd95f6b345d38c69eee4f6ddb958190
https://github.com/dreamwidth/dw-free/commit/941441147bd95f6b345d38c69eee4f6ddb958190
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
[#1983] fix one more occurrence of reference mismatch errors

Found 4 paths before; 5th path is obscure edge case where icon
is 100x100 or less, but file size is > $MAX_UPLOAD. I think
this edit removes the last direct references to $POST->{$userpic_key}
from parse_post_uploads. This is the error in the logs:

FATAL> BlobStore.pm:100 DW::BlobStore::store | Store requires data be a scalar reference. at /home/dw/production/cgi-bin/DW/Controller/EditIcons.pm line 215.


Commit: 8f7953dd1501b11c3db6f4a04f506e75b9916c18
https://github.com/dreamwidth/dw-free/commit/8f7953dd1501b11c3db6f4a04f506e75b9916c18
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
[#1855] improve handling of media load errors on /file/edit

1. Early return if we have a 'null' or undef mediaid.

2. Eval call to DW::Media->new so we return an API error
instead of croaking if it failed.

Fixes #1855.


Commit: 861a018829ee0ae2c67b2a490413c44550976e08
https://github.com/dreamwidth/dw-free/commit/861a018829ee0ae2c67b2a490413c44550976e08
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
additional headers for media file requests

Discussion with @alierak led to the conclusion that media files
should use the Cache-Control and Last-Modified headers.

Inspection of Apache/LiveJournal.pm and Apache/BML.pm indicates
that Cache-Control should be applied to all user content responses,
so we make that the new default behavior for user content in DW/Routing.pm.

The Last-Modified header is set in the media file controller as the
upload date of the file, which will never change.

Without the Last-Modified header, the image may be redownloaded
unnecessarily. Without the Cache-Control header, Cloudflare
caching may interfere with the ability to load the image correctly.


Compare: https://github.com/dreamwidth/dw-free/compare/e05fe1281a79...861a018829ee
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 7400b91371eecaf4e604b2085d35a05c72dfc5a5
https://github.com/dreamwidth/dw-free/commit/7400b91371eecaf4e604b2085d35a05c72dfc5a5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
additional headers for media file requests

Discussion with @alierak led to the conclusion that media files
should use the Cache-Control and Last-Modified headers.

Inspection of Apache/LiveJournal.pm and Apache/BML.pm indicates
that Cache-Control should be applied to all user content responses,
so we make that the new default behavior for user content in DW/Routing.pm.

The Last-Modified header is set in the media file controller as the
upload date of the file, which will never change.

Without the Last-Modified header, the image may be redownloaded
unnecessarily. Without the Cache-Control header, Cloudflare
caching may interfere with the ability to load the image correctly.


Commit: 8410894ea119c8fe13b0ccb88db949c9ece082f9
https://github.com/dreamwidth/dw-free/commit/8410894ea119c8fe13b0ccb88db949c9ece082f9
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm
M cgi-bin/DW/Routing.pm

Log Message:
-----------
Merge pull request #2003 from kareila/media-headers

additional headers for media file requests


Compare: https://github.com/dreamwidth/dw-free/compare/ecba2a889335...8410894ea119
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: e69b60fbd008183682bf8f910f54cc61c6e11ecd
https://github.com/dreamwidth/dw-free/commit/e69b60fbd008183682bf8f910f54cc61c6e11ecd
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf

Log Message:
-----------
[#1988] remove LJ/EventLogRecord.pm and submodules

Fixes #1988.


Commit: fd912965db3686b34ff5e93dd57551504e3d9280
https://github.com/dreamwidth/dw-free/commit/fd912965db3686b34ff5e93dd57551504e3d9280
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M t/post.t

Log Message:
-----------
removal of EventLogRecord from postevent causes test failures

Failed test 'Public security'
at t/post.t line 394.
got: undef
expected: 'public'

Failed test 'Public security'
at t/post.t line 403.
got: undef
expected: 'public'

Failed test 'Locked security'
at t/post.t line 415.
got: undef
expected: 'usemask'

In all three cases, changing $entry->{security} to $entry->security
fixed the problem, because that causes the object's hash data to be
populated. Previously, the data was populated within the context of
the EventLogRecord job in postevent.


Commit: 4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
https://github.com/dreamwidth/dw-free/commit/4e9b78b71e3eb1a093e29fc77fa6fad8daff13e7
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Entry.pm
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use another method to repopulate the entry object data

At first I thought I would need to audit the code for
uses of $entry->{security} instead of $entry->security,
and while I did find and change a few of those, I quickly
realized a less scattershot approach would be to drop in
another method call in place of the removed one that had
the same side effect of populating the data in the cached
entry object.

With that done, the failing test once again passes
(although I'm still committing the fixed version).


Commit: ecba2a889335572f0ff0125eee0d9ca1b9eda166
https://github.com/dreamwidth/dw-free/commit/ecba2a889335572f0ff0125eee0d9ca1b9eda166
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
R bin/worker/process-eventlogrecord
M cgi-bin/LJ/Entry.pm
R cgi-bin/LJ/EventLogRecord.pm
R cgi-bin/LJ/EventLogRecord/DeleteComment.pm
R cgi-bin/LJ/EventLogRecord/EditEntry.pm
R cgi-bin/LJ/EventLogRecord/NewComment.pm
R cgi-bin/LJ/EventLogRecord/NewEntry.pm
R cgi-bin/LJ/EventLogRecord/PropChanged.pm
R cgi-bin/LJ/EventLogRecord/SessionExpired.pm
R cgi-bin/LJ/EventLogRecord/UpdateUser.pm
M cgi-bin/LJ/Protocol.pm
M cgi-bin/LJ/Session.pm
M cgi-bin/LJ/Talk.pm
M cgi-bin/ljlib.pl
M etc/workers.conf
M t/post.t

Log Message:
-----------
Merge pull request #1994 from kareila/1988-EventLogRecord

[#1988] remove LJ/EventLogRecord.pm and submodules


Compare: https://github.com/dreamwidth/dw-free/compare/ea34b74fd0ae...ecba2a889335
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: c172a10daa9e7f9c6aea4a66f92581555d5f612f
https://github.com/dreamwidth/dw-free/commit/c172a10daa9e7f9c6aea4a66f92581555d5f612f
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
[#1855] improve handling of media load errors on /file/edit

1. Early return if we have a 'null' or undef mediaid.

2. Eval call to DW::Media->new so we return an API error
instead of croaking if it failed.

Fixes #1855.


Commit: ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
https://github.com/dreamwidth/dw-free/commit/ea34b74fd0aec085f95ebcbf236e6d24ed6cfeb2
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
Merge pull request #2002 from kareila/1855-null-mediaid

[#1855] improve handling of media load errors on /file/edit


Compare: https://github.com/dreamwidth/dw-free/compare/04b517843619...ea34b74fd0ae
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 4b4f745e77f45cb387c65819c5d7a15618c231ea
https://github.com/dreamwidth/dw-free/commit/4b4f745e77f45cb387c65819c5d7a15618c231ea
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-20 (Mon, 20 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
[#1983] fix one more occurrence of reference mismatch errors

Found 4 paths before; 5th path is obscure edge case where icon
is 100x100 or less, but file size is > $MAX_UPLOAD. I think
this edit removes the last direct references to $POST->{$userpic_key}
from parse_post_uploads. This is the error in the logs:

FATAL> BlobStore.pm:100 DW::BlobStore::store | Store requires data be a scalar reference. at /home/dw/production/cgi-bin/DW/Controller/EditIcons.pm line 215.


Commit: 04b51784361961dfcbbd70112b08b0cf49b901d0
https://github.com/dreamwidth/dw-free/commit/04b51784361961dfcbbd70112b08b0cf49b901d0
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
Merge pull request #2001 from kareila/1983-autoscale

[#1983] fix one more occurrence of reference mismatch errors


Compare: https://github.com/dreamwidth/dw-free/compare/e94a1a9b5351...04b517843619
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
https://github.com/dreamwidth/dw-free/commit/1ded4d41bdbdc67252bbcc7840e8f8d4dd3c9f78
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
use correct user object when deleting existing slugs

Fixes #1992.


Commit: e94a1a9b5351bdbc75ba2acb971cc0770237a584
https://github.com/dreamwidth/dw-free/commit/e94a1a9b5351bdbc75ba2acb971cc0770237a584
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/LJ/Protocol.pm

Log Message:
-----------
Merge pull request #1993 from kareila/1992-edit-slugs

use correct user object when deleting existing slugs


Compare: https://github.com/dreamwidth/dw-free/compare/b49f98c67974...e94a1a9b5351
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: eb9640e01dd422685ec586c2cef703c0474d49c5
https://github.com/dreamwidth/dw-free/commit/eb9640e01dd422685ec586c2cef703c0474d49c5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Feeds.pm

Log Message:
-----------
fix undefined warning in DW/Controller/Feeds.pm

Use of uninitialized value in pattern match (m//) at /home/dw/production/cgi-bin/DW/Controller/Feeds.pm line 72.


Commit: 29afdd466c3857ecf573dbbbed8d9226a56682f6
https://github.com/dreamwidth/dw-free/commit/29afdd466c3857ecf573dbbbed8d9226a56682f6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix undefined warning in DW/Controller/EditIcons.pm

Use of uninitialized value in string eq .. cgi-bin/DW/Controller/EditIcons.pm line 163.


Commit: 60d05bad8ddbd27c656865e8db30679289757d13
https://github.com/dreamwidth/dw-free/commit/60d05bad8ddbd27c656865e8db30679289757d13
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
fix undefined warning in LJ/Userpic.pm

Use of uninitialized value $w in numeric ge (>=) .. cgi-bin/LJ/Userpic.pm line 682.


Commit: b2ab126f4681dd98e213752dfaa2f105154a9b64
https://github.com/dreamwidth/dw-free/commit/b2ab126f4681dd98e213752dfaa2f105154a9b64
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/Poll.pm

Log Message:
-----------
avoid die statement in LJ/Poll.pm

Error loading poll id: 1903855: Invalid journalid at /home/dw/production/cgi-bin/LJ/Poll.pm line 558.

This seemed the best course of action, since we're also
returning undef if the subsequent row lookup fails.


Commit: 1b9abedbfbaf852114844964841b8d6209026698
https://github.com/dreamwidth/dw-free/commit/1b9abedbfbaf852114844964841b8d6209026698
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
avoid calling method on undefined object in DW/Routing.pm

Can't call method "journal_base" on an undefined value at /home/dw/production/cgi-bin/DW/Routing.pm line 209

Tweak the conditional logic so that $renamed_u must be
valid if we want to redirect to it.


Commit: ae9ef2cf874669c36829ad8b13129a0b4770ba8e
https://github.com/dreamwidth/dw-free/commit/ae9ef2cf874669c36829ad8b13129a0b4770ba8e
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/ChangeEmail.pm

Log Message:
-----------
fix undefined warning in DW/Controller/ChangeEmail.pm

Use of uninitialized value in string ne at /home/dw/production/cgi-bin/DW/Controller/ChangeEmail.pm line 84.

First, we don't need to check is_identity when assigning $password,
because we check for it in the conditional.

Second, we should actually use $password if we assign it.

Third, put the short-circuit check ($remote->is_identity)
first, to avoid unnecessarily checking a string that will
be undefined in that particular case.

Fourth, OK to error if $password is undef, since that can never be
the correct password. Identity accounts can have undefined pws
but we've already accounted for that.


Commit: 850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
https://github.com/dreamwidth/dw-free/commit/850cf4c5e7d32fae34f6637e1dfa8fb158abd0d6
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-16 (Thu, 16 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm

Log Message:
-----------
fix undefined warning in DW/Controller/API/Media.pm

Use of uninitialized value $type in numeric eq (==) at /home/dw/production/cgi-bin/DW/Controller/API/Media.pm line 74.


Commit: 1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
https://github.com/dreamwidth/dw-free/commit/1fd3c0fc6e78ba7023977b5b0bb4e611603f582a
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Routing.pm

Log Message:
-----------
remove unused variable from DW::Routing


Commit: b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
https://github.com/dreamwidth/dw-free/commit/b49f98c67974ec37a9cf7b167e99a31bfd1e4b47
Author: Mark Smith <mark@qq.is>
Date: 2017-02-21 (Tue, 21 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/API/Media.pm
M cgi-bin/DW/Controller/ChangeEmail.pm
M cgi-bin/DW/Controller/EditIcons.pm
M cgi-bin/DW/Controller/Feeds.pm
M cgi-bin/DW/Routing.pm
M cgi-bin/LJ/Poll.pm
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
Merge pull request #1991 from kareila/cleanup-2017q1

Post-push log cleanup


Compare: https://github.com/dreamwidth/dw-free/compare/fd10742691d7...b49f98c67974
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
https://github.com/dreamwidth/dw-free/commit/2c5a6d52678d3ad7a913f96a8b6b58e4e71a54cd
Author: Mark Smith <mark@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Use of $# considered harmful

This construction returns the index of the last item rather than the
count which means this was only returning true once the file had
replicated, which while often successful is definitely not what we want.


Commit: fd10742691d7fa50859287df90ab77a2a9145ba3
https://github.com/dreamwidth/dw-free/commit/fd10742691d7fa50859287df90ab77a2a9145ba3
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Merge pull request #1986 from zorkian/fix-off-by-one

Use of $# considered harmful


Compare: https://github.com/dreamwidth/dw-free/compare/0cf1d70e3879...fd10742691d7

Changelog Digest for Wed, Feb 15

Feb. 15th, 2017 10:13 am
kareila: "Mom, I'm hungry." "Hush, I'm coding. You ate yesterday." (coding)
[personal profile] kareila posting in [community profile] changelog_digest

These are live on the site:

[dw-free]

2bd9807: Issue #1936: Most-requested file-manager tweaks for roll-out
Fix missing single quote in thumbnail embed text.
3d7b6a1: Issue #1981: HTML cleaner no longer autolinkifying URLs
Anchor regular expression in break_word subroutine.
993d91d: Issue #1940: we should determine and enforce limits for media hosting
Fix remote checking for access control of media files.
48f7f7b: Issue #1940: we should determine and enforce limits for media hosting
Allow hotlinking from crosspost sites.
47b3933: Issue #1983: fix uploading of non-factory, non-URL icons
Correctly handle a variety of inputs to the parse_post_uploads function.
e05fe12: Issue #1983: fix uploading of non-factory, non-URL icons
Hotfix for checking number of paths in 'exists' method.

These are in the queue for the next code push:

[dw-free]

1887e53: Issue #1978: re-enable stats graph printing
Remove early return from stats.bml.
368182a: Issue #1978: re-enable stats graph printing
Graph printing logic improvements.
04389dd: Issue #1977: change LF to CRLF in graph labels to display properly
Fix character glitch in automatically generated stats graphs.
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/release-1.32
Home: https://github.com/dreamwidth/dw-free
Commit: b2935b6a3d9179cc462026dce027c18430b5c99b
https://github.com/dreamwidth/dw-free/commit/b2935b6a3d9179cc462026dce027c18430b5c99b
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
fix remote checking for access control of media files

Use a controller to do basic setup checking, including
bouncing for a user domain cookie if needed - LJ::get_remote
was failing when the user domain cookie wasn't available.

With that working, we can add functional support for viewall,
and remove the FIXME comment that requested it.


Commit: 351835ae5c14b522c6e00f974ac64d4e14848046
https://github.com/dreamwidth/dw-free/commit/351835ae5c14b522c6e00f974ac64d4e14848046
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
[#1940] allow hotlinking from crosspost sites

As @kaberett pointed out, crossposted entries that reference
hosted images will fail to load on the remote site, so let's
whitelist all known crosspost sites.


Commit: 7a1eae0cd8a4ca7af94a13767402cbb86058d907
https://github.com/dreamwidth/dw-free/commit/7a1eae0cd8a4ca7af94a13767402cbb86058d907
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
[#1981] anchor regexp in break_word subroutine

Fixes #1981.


Commit: 94014d42e6452365cf3e99f875a1e0dde5f52ed5
https://github.com/dreamwidth/dw-free/commit/94014d42e6452365cf3e99f875a1e0dde5f52ed5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix uploading of all sizes of icons

I've tested editicons on my hack with this fix in place and
all FOUR upload flows (small, medium, large, and URL) seem
to work fine now for me.


Commit: e05fe1281a795d05ee2fb36e7f04c77edab23790
https://github.com/dreamwidth/dw-free/commit/e05fe1281a795d05ee2fb36e7f04c77edab23790
Author: Mark Smith <mark@qq.is>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/BlobStore/MogileFS.pm

Log Message:
-----------
Hotfix for checking number of paths in 'exists' method.


Compare: https://github.com/dreamwidth/dw-free/compare/2bd9807410de...e05fe1281a79
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 47b3933b5ab574d8f56d2f5b2ab1ba1fff83a340
https://github.com/dreamwidth/dw-free/commit/47b3933b5ab574d8f56d2f5b2ab1ba1fff83a340
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
fix uploading of all sizes of icons

I've tested editicons on my hack with this fix in place and
all FOUR upload flows (small, medium, large, and URL) seem
to work fine now for me.


Commit: 0cf1d70e38795791f5b974d1a95a7721efaa7a71
https://github.com/dreamwidth/dw-free/commit/0cf1d70e38795791f5b974d1a95a7721efaa7a71
Author: Jen <kareila@dreamwidth.org>
Date: 2017-02-15 (Wed, 15 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/EditIcons.pm

Log Message:
-----------
Merge pull request #1983 from kareila/editicons-fix

fix uploading of non-factory, non-URL icons


Compare: https://github.com/dreamwidth/dw-free/compare/3b9f7ac308a6...0cf1d70e3879

Dreamwidth news: 15 February 2017

Feb. 15th, 2017 05:35 am
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)
[staff profile] denise posting in [site community profile] dw_news
Hello, Dreamwidth! And thank you to everyone who wished me and my wife a happy vacation -- it was an excellent one. (Rumors that it was to help distract me from a significant birthday starting with 4 and ending with 0 are totally unfounded. Really.) It was also awesome to come back and see all of the new activity going on! I hope that everyone who's joined us in the last month or two has been settling in nicely.

Behind the cut, a tour of some of the new stuff we've done in the last few months, plus a look at some older changes that could use more love:

* Image Hosting Frontend
* HTTPS Beta
* Create Entries Beta: progress report
* Selective comment screening
* Other alphabets in site search: fixed!
* Icon file size limit increased
* Dreamwidth: Did You Know?
* Team Dreamwidth

DW News, 15 Feb 2017 )

*

That's it from us for another update! As always, if you're having problems with Dreamwidth, Support can help you; for notices of site problems and downtime, check the Twitter status page.

Comment notifications may be delayed for an hour or two, due to the high volume of notifications generated after an update is posted to [site community profile] dw_news. This was posted at 5:35AM EST (see in your time zone). Please don't worry about delayed notifications until at least two hours after that.
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 04389dda95709fee16ca73ae74b05a6f24fbba78
https://github.com/dreamwidth/dw-free/commit/04389dda95709fee16ca73ae74b05a6f24fbba78
Author: Robby Griffin <rmg@rmg-mbpr-3.local>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Graphs.pm
M cgi-bin/DW/Graphs.pm

Log Message:
-----------
change LF to CRLF in graph labels to display properly


Commit: 3b9f7ac308a657e6a770a3476316bb56727990e1
https://github.com/dreamwidth/dw-free/commit/3b9f7ac308a657e6a770a3476316bb56727990e1
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Graphs.pm
M cgi-bin/DW/Graphs.pm

Log Message:
-----------
Merge pull request #1977 from alierak/graph_labels_crlf

change LF to CRLF in graph labels to display properly


Compare: https://github.com/dreamwidth/dw-free/compare/79954c51a1ec...3b9f7ac308a6
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 993d91d280f8983ea3799f7411213affb43efd35
https://github.com/dreamwidth/dw-free/commit/993d91d280f8983ea3799f7411213affb43efd35
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
fix remote checking for access control of media files

Use a controller to do basic setup checking, including
bouncing for a user domain cookie if needed - LJ::get_remote
was failing when the user domain cookie wasn't available.

With that working, we can add functional support for viewall,
and remove the FIXME comment that requested it.


Commit: 48f7f7b18cf7312855565d58d6656b3a64d6ad7c
https://github.com/dreamwidth/dw-free/commit/48f7f7b18cf7312855565d58d6656b3a64d6ad7c
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
[#1940] allow hotlinking from crosspost sites

As @kaberett pointed out, crossposted entries that reference
hosted images will fail to load on the remote site, so let's
whitelist all known crosspost sites.


Commit: 79954c51a1ec867f4b2865f936924a72361458f7
https://github.com/dreamwidth/dw-free/commit/79954c51a1ec867f4b2865f936924a72361458f7
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
Merge pull request #1980 from kareila/1960-crossposts

fixes for media file access


Compare: https://github.com/dreamwidth/dw-free/compare/912dd34fe3f9...79954c51a1ec
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 1887e5374ef596480f54c8dd762ca95d5fe98ea5
https://github.com/dreamwidth/dw-free/commit/1887e5374ef596480f54c8dd762ca95d5fe98ea5
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M htdocs/stats.bml

Log Message:
-----------
remove early return from stats.bml

This early return prevented the "pretty graphs" from being
printed, with a comment saying they were broken. @alierak
says they are not broken - looks like newbyday.png is
generated by bin/maint/statspics.pl. The early return
dates from the original LJ import.


Commit: 368182a36b41ef83a9c6c7065654c59c4d641b40
https://github.com/dreamwidth/dw-free/commit/368182a36b41ef83a9c6c7065654c59c4d641b40
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M htdocs/stats.bml
M htdocs/stats.bml.text

Log Message:
-----------
graph printing logic improvements

While we're here, only try to display the image if the
image file exists, and English-strip the text.


Commit: 912dd34fe3f9fd5ab1a3485dee1c8b3339618861
https://github.com/dreamwidth/dw-free/commit/912dd34fe3f9fd5ab1a3485dee1c8b3339618861
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M htdocs/stats.bml
M htdocs/stats.bml.text

Log Message:
-----------
Merge pull request #1978 from kareila/show_stats_graph

re-enable stats graph printing


Compare: https://github.com/dreamwidth/dw-free/compare/b1ba2b6613e0...912dd34fe3f9
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 3d7b6a1134b0b86e442f374a3e5aa15de3368376
https://github.com/dreamwidth/dw-free/commit/3d7b6a1134b0b86e442f374a3e5aa15de3368376
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
[#1981] anchor regexp in break_word subroutine

Fixes #1981.


Commit: b1ba2b6613e09bf4bfd44f513cf365e1703c7ef1
https://github.com/dreamwidth/dw-free/commit/b1ba2b6613e09bf4bfd44f513cf365e1703c7ef1
Author: Mark Smith <mark@qq.is>
Date: 2017-02-14 (Tue, 14 Feb 2017)

Changed paths:
M cgi-bin/LJ/CleanHTML.pm
M t/clean-event.t

Log Message:
-----------
Merge pull request #1982 from kareila/1981-entities

[#1981] anchor regexp in break_word subroutine


Compare: https://github.com/dreamwidth/dw-free/compare/2bd9807410de...b1ba2b6613e0
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/release-1.32
Home: https://github.com/dreamwidth/dw-free
Commit: 2bd9807410def80a06f10a97a1f1cb36b51434fb
https://github.com/dreamwidth/dw-free/commit/2bd9807410def80a06f10a97a1f1cb36b51434fb
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
[#1936] fix missing single quote in thumbnail embed text
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 2bd9807410def80a06f10a97a1f1cb36b51434fb
https://github.com/dreamwidth/dw-free/commit/2bd9807410def80a06f10a97a1f1cb36b51434fb
Author: Kareila <kareila@dreamwidth.org>
Date: 2017-02-13 (Mon, 13 Feb 2017)

Changed paths:
M cgi-bin/DW/Controller/Media.pm

Log Message:
-----------
[#1936] fix missing single quote in thumbnail embed text

Changelog Digest for Mon, Feb 13

Feb. 13th, 2017 12:39 am
kareila: "PERL!" (perl)
[personal profile] kareila posting in [community profile] changelog_digest

[dw-free]

1b9651f: Issue #1907: strip off http/https when checking OpenID logins
When given an https OpenID, check both https and http for existing accounts.
7d32498: Issue #1907: strip off http/https when checking OpenID logins
Use LJ::User::load_existing_identity_user where appropriate.
24848d0: Issue #1744: Replying to PMs from OpenID users should Just Work but Really Doesn't
Use username, not display_name, in msg_to form field.
eff1ff1: Issue #1939: don't let someone try to claim a deleted OpenID account
Return an error if trying to claim a deleted account.
6543945: Issue #1963: remove bin/ljubackup.pl
Remove unused admin script for database maintenance.
b554607: Issue #1963: remove bin/ljubackup.pl
Remove database table only used by the script we just removed.
005e4ee: Issue #1968: whitelist iframe embeds from scratch.mit.edu
Allow embedded content from scratch.mit.edu.
578c6fe: Issue #1967: allow etc/log4perl.conf to be superceded by ext/local
Use LJ::resolve_file like we do for other config files.
5a9dbc6: Issue #1967: allow etc/log4perl.conf to be superceded by ext/local
Add comments explaining other log levels.
8bbcf3a: Issue #1915: ConfCheck
Remove unused ConfCheck modules.
27853cf: Issue #1325: http://www.dreamwidth.org/file/edit doesn't work with trailing slash
Let register_string redirect pagename/ to pagename.
995fa7a: Issue #1962: Migrate userpicblob2 icons
Resurrect old version of migrate-userpics.pl.
3b8996c: Issue #1962: Migrate userpicblob2 icons
Move userpicblob2 data to blobstore.
dc72fb7: Issue #1962: Migrate userpicblob2 icons
Use custom log4perl config.
f372661: Issue #1964: Blobstore-related cleanup
Cleanup in checkconfig.pl.
3a348ba: Issue #1964: Blobstore-related cleanup
Stop including MogileFS::Client in modperl_subs.pl.
4c55256: Issue #1964: Blobstore-related cleanup
Incorrect file name in header of blobstore.t.
8aa43ed: Issue #1964: Blobstore-related cleanup
Remove other textual MogileFS references.
2f2ad76: Issue #1942: link to file management in CORES menu
Add file/new, file/edit to menunav.
23f2544: Issue #1942: link to file management in CORES menu
Don't let OpenID users upload files.
1866146: Issue #1975: Live updates
Update importer.
d6e83bd: Issue #1975: Live updates
More updates from production.
774f909: Issue #1931: Backend: deleting an image on /file/edit deletes the original but not the thumbnail
Delete associated thumbnails when a media image is deleted.
e69e7d5: Issue #1940: we should determine and enforce limits for media hosting
Don't count deleted files against quotas.
ef8d801: Issue #1931: Backend: deleting an image on /file/edit deletes the original but not the thumbnail
Incorporate feedback from code review.

Profile

denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)
Denise

July 2015

S M T W T F S
   1234
567891011
12131415161718
19202122232425
26272829 3031 

Most Popular Tags

Page Summary

Style Credit

Expand Cut Tags

No cut tags
Page generated Feb. 23rd, 2017 04:45 am
Powered by Dreamwidth Studios