Changelog Digest for Wed, Aug 20

Aug. 20th, 2014 10:07 am
kareila: "PERL!" (perl)
[personal profile] kareila posting in [community profile] changelog_digest

[dw-free]

3036626: Issue #940: no_mobile cookie not persisting
Add an expiration date to let cookie persist past the end of the session.
1865ae5: Issue #939: Adds journal sub+title to beta update previews
Use journal titles instead of user names in beta update preview page.
4d28337: Issue #925: Use LJ::Error and display an actual error message
User friendly error display instead of ugly Perl "die" output.
a7a8a8a: Issue #444 (Bug #5115): Only one pic#xxx icon may be renamed.
Make sure we always have a mapid and update the relevant DB table to use it.
sophie: A cartoon-like representation of a girl standing on a hill, with brown hair, blue eyes, a flowery top, and blue skirt. ☀ (Default)
[personal profile] sophie posting in [site community profile] dw_dev
I just updated LWPx::ParanoidAgent and Net::SSL on the Dreamhacks server - something that I've needed to do for some time. In the process about seventy bajillion other modules that they relied on needed to be updated, too (mainly to do with HTTP/SSL stuff) so the following modules (and any submodules included in their distribution) are now at their most recent (and the links given lead to the exact versions installed from CPAN):

23 different distributions in total )

As this is rather a lot of modules, some of which can be core to various things that the codebase does, you should restart your Apache if it's currently running; there may be errors otherwise. Also, it's possible that the update of these modules might somehow cause brokenness in some areas on the Dreamhacks server; please do comment here if that's the case (or open a GitHub issue).

(Please note: This only applies to brokenness on the Dreamhacks server. Nothing has changed on dreamwidth.org, so any issues there should be raised in a Support request as usual.)

Error message from the wiki engine?

Aug. 19th, 2014 05:21 pm
pauamma: Cartooney crab holding drink (Default)
[personal profile] pauamma posting in [site community profile] dw_wiki
I'm getting a bunch of repeats of
Notice: Undefined offset: 0 in /var/www/wiki/extensions/SyntaxHighlight_GeSHi/geshi/geshi.php on line 4531 Notice: Undefined offset: 4 in /var/www/wiki/extensions/SyntaxHighlight_GeSHi/geshi/geshi.php on line 4531
when viewing http://wiki.dreamwidth.net/wiki/index.php/Newbie_Guide:_How_to_Patch_Styles_and_Themes, and I suspect, a number of other pages. (This is the only page so far for which the messages remain visible after the page itself displays, but I noticed transient messages on other pages that may be the same.) Is it just me, or is anyone else getting those or similar messages?

Mobile Styles: options

Aug. 18th, 2014 03:40 pm
fu: Close-up of Fu, bringing a scoop of water to her mouth (Default)
[staff profile] fu posting in [site community profile] dw_styles
Since the last time I posted, we've made live some additional tweaks for mobile styles. Medium sized screens (tablet / phone landscape) should in general handle the ratio of sidebar to content better, and not let the sidebar crowd into the content as much. Comments should also no longer go into one-word-per-line in extreme cases on certain layouts, and should always have a background even if they're so deeply threaded that they start going past the sidebar.

But of course what works in general may not work for your journal! So there's one set of options that's journal-specific.

If you're mostly happy with how things appear, but want to tweak the width at which changes are applied to your journal, go to your journal display settings > Additional Options, and then look for

"The width at which the layout switches from single column mode (mobile view) to multiple columns if selected (tablet view). "

and

"The width at which the layout switches to larger screen mode (desktop view) and can afford some extra whitespace. "

Setting a width in the first option will make the biggest difference; the second option should only be minor whitespace tweaks depending on the layout.


Meanwhile, if what you want is to control how you view journals across all of Dreamwidth, there's a different option for that. If you'd like to always view the desktop / big screen version on your mobile phone or tablet, go to your Account Display Settings and check "Turn off mobile view for this device".

That will carry over to all journals you view whether you're logged in or logged out. It's device-specific* so if things work on your phone but not your tablet, or vice versa, you can check or uncheck this setting per-device.

* more accurately, it's browser-specific. If you're using multiple browsers on a device, you'll have to check it for each browser.

Layout: Dotted line

Aug. 15th, 2014 10:27 pm
rosecarmine: (Default)
[personal profile] rosecarmine posting in [site community profile] dreamscapes
Name: Dotted line
Author: [personal profile] rosecarmine
Image info: Metadata images by p.yusukekamiyamane.com (license)

Layout layer: Info | Source | Syntax Highlighted
Theme layer: Info | Source | Syntax Highlighted | Preview
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: a7a8a8af2592d43af7a5290ee7e1606261214a4c
https://github.com/dreamwidth/dw-free/commit/a7a8a8af2592d43af7a5290ee7e1606261214a4c
Author: purplecat <purplecat@dreamwidth.org>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/LJ/Userpic.pm
A t/userpics_nokeywords.t

Log Message:
-----------
[#444] Fix renaming of unused pic#xxx icons

The error was being caused because, in a situation where an icon wasn't
being used, no mapid was created and the icon instead gained the mapid
of 0.

This meant the table row was overwritten in any attempt to rename
another anonymous icon, since again the mapid was set to 0.

Fix is to make sure we generate a new mapid if it doesn't already exist,
then update the userpicmap3 row for this pic#xxx so that it points to
the correct (renamed to) keyword.

Commit includes a test for the renaming of userpics with no keywords.


Commit: 9b542b7e909f27f7106babba9b4b4c53bbc6e574
https://github.com/dreamwidth/dw-free/commit/9b542b7e909f27f7106babba9b4b4c53bbc6e574
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/LJ/Userpic.pm
A t/userpics_nokeywords.t

Log Message:
-----------
Merge pull request #939 'renaming-unused-picxxx-bug-444' into develop

* renaming-unused-picxxx-bug-444:
[#444] Fix renaming of unused pic#xxx icons


Compare: https://github.com/dreamwidth/dw-free/compare/35c81de67da9...9b542b7e909f
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/release-1.22
Home: https://github.com/dreamwidth/dw-free
Commit: 4d283379f80156062be9bca036e9508feffbfd19
https://github.com/dreamwidth/dw-free/commit/4d283379f80156062be9bca036e9508feffbfd19
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-11 (Mon, 11 Aug 2014)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
Use LJ::Error and display an actual error message

(instead of splatting across the top of the screen)


Commit: 56696f93d86ac9c943675891d464ad2dfe7de9aa
https://github.com/dreamwidth/dw-free/commit/56696f93d86ac9c943675891d464ad2dfe7de9aa
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/LJ/Userpic.pm

Log Message:
-----------
Merge pull request #925 from afuna/userpic-display-error-message

Use LJ::Error and display an actual error message


Compare: https://github.com/dreamwidth/dw-free/compare/c15f5b97bd8c...56696f93d86a
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 1865ae51a337bfbbc4bb26b6e8b40c5a4232a22e
https://github.com/dreamwidth/dw-free/commit/1865ae51a337bfbbc4bb26b6e8b40c5a4232a22e
Author: kaberett <kaberett@dreamwidth.org>
Date: 2014-08-13 (Wed, 13 Aug 2014)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm

Log Message:
-----------
Adds journal sub+title to beta update previews


Commit: 35c81de67da9c92c98df593a1907e5656f488611
https://github.com/dreamwidth/dw-free/commit/35c81de67da9c92c98df593a1907e5656f488611
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/DW/Controller/Entry.pm

Log Message:
-----------
Merge pull request #939 from kaberett/beta-update-preview-title

Adds journal sub+title to beta update previews


Compare: https://github.com/dreamwidth/dw-free/compare/29d39687ce36...35c81de67da9
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 60f476cf3aeb856f9b22ab6dd54f00db5453139d
https://github.com/dreamwidth/dw-free/commit/60f476cf3aeb856f9b22ab6dd54f00db5453139d
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-11 (Mon, 11 Aug 2014)

Changed paths:
M cgi-bin/DW/Setting/MobileView.pm

Log Message:
-----------
Return an explicit value (1/0) instead of potentially undef

To avoid an "Odd number of elements in anonymous hash" warning


Commit: 07ea6d46d87549f44a3f6637fc205f3f0c335d41
https://github.com/dreamwidth/dw-free/commit/07ea6d46d87549f44a3f6637fc205f3f0c335d41
Author: Mark Smith <mark@qq.is>
Date: 2014-08-10 (Sun, 10 Aug 2014)

Changed paths:
M cgi-bin/DW/Setting/MobileView.pm

Log Message:
-----------
Merge pull request #924 from afuna/explicit-return-mobile-view

Return an explicit value (1/0) instead of potentially undef


Commit: 3036626a3175eb43471ee45193a2bbda6f3a6720
https://github.com/dreamwidth/dw-free/commit/3036626a3175eb43471ee45193a2bbda6f3a6720
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/DW/Setting/MobileView.pm

Log Message:
-----------
[#940] Make the no_mobile cookie stick around for 10 years

Fixes #940.


Commit: c15f5b97bd8c94760d64c6c63b3598903ff8524f
https://github.com/dreamwidth/dw-free/commit/c15f5b97bd8c94760d64c6c63b3598903ff8524f
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/DW/Setting/MobileView.pm

Log Message:
-----------
Merge pull request #941 from afuna/no_mobile-persist-bug-940

[#940] Make the no_mobile cookie stick around for 10 years


Commit: 29d39687ce36138ebd3362792b5c652559671ebc
https://github.com/dreamwidth/dw-free/commit/29d39687ce36138ebd3362792b5c652559671ebc
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/DW/Setting/MobileView.pm

Log Message:
-----------
Merge branch 'release-1.22' into develop

* release-1.22:
[#940] Make the no_mobile cookie stick around for 10 years
Return an explicit value (1/0) instead of potentially undef


Compare: https://github.com/dreamwidth/dw-free/compare/a31bcb37f480...29d39687ce36
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/release-1.22
Home: https://github.com/dreamwidth/dw-free
Commit: 3036626a3175eb43471ee45193a2bbda6f3a6720
https://github.com/dreamwidth/dw-free/commit/3036626a3175eb43471ee45193a2bbda6f3a6720
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/DW/Setting/MobileView.pm

Log Message:
-----------
[#940] Make the no_mobile cookie stick around for 10 years

Fixes #940.


Commit: c15f5b97bd8c94760d64c6c63b3598903ff8524f
https://github.com/dreamwidth/dw-free/commit/c15f5b97bd8c94760d64c6c63b3598903ff8524f
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-15 (Fri, 15 Aug 2014)

Changed paths:
M cgi-bin/DW/Setting/MobileView.pm

Log Message:
-----------
Merge pull request #941 from afuna/no_mobile-persist-bug-940

[#940] Make the no_mobile cookie stick around for 10 years


Compare: https://github.com/dreamwidth/dw-free/compare/07ea6d46d875...c15f5b97bd8c

Dreamwidth: Quote #671

Aug. 14th, 2014 02:43 am
[personal profile] figment_bot posting in [community profile] dwqdb
(11:37:48 AM) rahaeli: zorkian: i am doing a thing!
(11:38:01 AM) rahaeli: it is hilariously out of my competency level, lol

(11:41:36 AM) zorkian: The only way to grow one's competency!
(11:41:54 AM) zorkian: Is to fling yourself at the wall with determination and a medic on standby



#671 -- #dreamwidth-dev, 2014-08-14 - submitted by [info - DW]jl_baldridge in Dreamwidth

Changelog Digest for Wed, Aug 13

Aug. 13th, 2014 03:12 pm
kareila: "PERL!" (perl)
[personal profile] kareila posting in [community profile] changelog_digest

[dw-free]

38acf2e: Issue #920: "Last Used" does not update on http://www.dreamwidth.org/oauth/
Set lastaccess to initial create time, to avoid confusion.
9325ee6: Issue #921: Fix for minimal set of system-installed libraries
Change load order and make sure all required libraries are included.
60f476c: Issue #924: Return an explicit value (1/0) instead of potentially undef
Avoid potential "Odd number of elements in anonymous hash" warning.
77756b4: Issue #926: Remove obsolete print_meta_viewport function declaration
Remove short-lived core2 function that is no longer defined in the backend.
b06e188: Issue #928: Slug URLs not accepted everywhere
Remove permalink TODO from new entry page.
85ed769: Issue #928: Slug URLs not accepted everywhere
Use LJ::Entry methods to grab the url.
eb13e28: Issue #928: Slug URLs not accepted everywhere
Use LJ::Entry->url when generating feeds.
76a0216: Issue #928: Slug URLs not accepted everywhere
Switch from LJ::item_link to $entry->url.
a1bf272: Issue #930: Use style_opts instead of style_args in the entry url
Change paramater name to be consistent with established usage.
14ae82c: Issue #933: Get rid of horizontal scrollbar
In Celerity: fix CSS to eliminate horizontal scrollbar.
6e282a9: Issue #936: add youtube as a site recognized by the account-linking tag
Allow <user site="youtube.com"> links to work.
5cfdc76: Issue #934: Add "Edit entry again" to Journal entry was edited Success page
Include option to edit the entry again in success links when editing.
e7329db: Issue #938: Tweak whitespace for queues (used in moderation entry queue)
CSS tweaks to spacing in display of moderated entry queue.

[dw-nonfree]

30d51db: Issue #80: Only add current status to the list of labels if we have the status
Avoid confusing the Github API with null data.
7b9af90: Issue #81: Get rid of horizontal scrollbar
In Tropo styles: fix CSS to eliminate horizontal scrollbar.
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: e7329dba9ebd2bb859c58de1c2fdf50a9f212783
https://github.com/dreamwidth/dw-free/commit/e7329dba9ebd2bb859c58de1c2fdf50a9f212783
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-13 (Wed, 13 Aug 2014)

Changed paths:
M htdocs/scss/components/queues.scss
M views/communities/queue/entries.tt
M views/dev/style-guide.tt

Log Message:
-----------
Tweak whitespace for queues (used in moderation entry queue)

* move the .row class inside the li.queue-item in order to keep the
whitespace to the left and right

* add padding to the left/right of the queue item

* remove the margin from ul.queue


Commit: a31bcb37f48083c43c4ce773a75af12679b37aaf
https://github.com/dreamwidth/dw-free/commit/a31bcb37f48083c43c4ce773a75af12679b37aaf
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-13 (Wed, 13 Aug 2014)

Changed paths:
M htdocs/scss/components/queues.scss
M views/communities/queue/entries.tt
M views/dev/style-guide.tt

Log Message:
-----------
Merge pull request #938 from afuna/queues-tweak

Tweak whitespace for queues (used in moderation entry queue)


Compare: https://github.com/dreamwidth/dw-free/compare/f663396449c2...a31bcb37f480

Dreamwidth: Quote #670

Aug. 13th, 2014 03:58 am
[personal profile] figment_bot posting in [community profile] dwqdb
(8:43:02 PM) tt: so currently I am considering a small lizard near my hip
(8:43:11 PM) tt: I have been imagining it on my left hip, but I suppose either would work
(8:43:32 PM) Amianym: :D
(8:43:34 PM) Amianym: leeeezard
(8:52:33 PM) azetidine left the room (quit: Quit: Leaving.).
(8:55:49 PM) zorkian: this conversatoin makes more sense when I saw it mentions tattoos




#670 -- #dreamwidth, 2014-08-13 - submitted by [info - DW]amianym in Dreamwidth

github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 5cfdc76b51bc4ff2b4d59323e85391033265ea48
https://github.com/dreamwidth/dw-free/commit/5cfdc76b51bc4ff2b4d59323e85391033265ea48
Author: Denise Paolucci <denise@dreamwidth.org>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M htdocs/editjournal.bml

Log Message:
-----------
Add 'edit entry again' to Journal entry was edited Success page
Fixes #934. From suggestions.


Commit: f663396449c20b574486ad3248b5cd7984e4151e
https://github.com/dreamwidth/dw-free/commit/f663396449c20b574486ad3248b5cd7984e4151e
Author: Mark Smith <mark@qq.is>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M htdocs/editjournal.bml

Log Message:
-----------
Merge pull request #935 from rahaeli/editagain

Add 'edit entry again' to Journal entry was edited Success page


Compare: https://github.com/dreamwidth/dw-free/compare/625a2ee69cd7...f663396449c2
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 6e282a9721b401007d61eaf091718b906e7cce3c
https://github.com/dreamwidth/dw-free/commit/6e282a9721b401007d61eaf091718b906e7cce3c
Author: Denise Paolucci <denise@dreamwidth.org>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M cgi-bin/DW/External/Site.pm
A cgi-bin/DW/External/Site/YouTube.pm

Log Message:
-----------
add youtube as a site recognized by the account-linking tag
Fixes #936. From suggestions.


Commit: 625a2ee69cd7dd19c2cf33bd221bbe96045c6ac3
https://github.com/dreamwidth/dw-free/commit/625a2ee69cd7dd19c2cf33bd221bbe96045c6ac3
Author: Mark Smith <mark@qq.is>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M cgi-bin/DW/External/Site.pm
A cgi-bin/DW/External/Site/YouTube.pm

Log Message:
-----------
Merge pull request #937 from rahaeli/youtube

add youtube as a site recognized by the account-linking tag


Compare: https://github.com/dreamwidth/dw-free/compare/43e365a0acba...625a2ee69cd7

(no subject)

Aug. 12th, 2014 12:20 pm
denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)
[staff profile] denise posting in [site community profile] dw_maintenance
Some people are reporting having trouble reaching the site, especially from the UK/EU. Unfortunately, after looking into it, it seems to be an internet routing problem and not something we can fix on our end. Hang tight; our hosting service is pretty good at working around those sorts of problems pretty quickly.
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: 14ae82c770ef6c2561596a345d42fc6c0d0cc20c
https://github.com/dreamwidth/dw-free/commit/14ae82c770ef6c2561596a345d42fc6c0d0cc20c
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M htdocs/scss/skins/celerity.scss

Log Message:
-----------
Get rid of horizontal scrollbar

Use padding instead of positioning so that it doesn't affect page width


Commit: 43e365a0acba3aed2676e68795fce5338cc35541
https://github.com/dreamwidth/dw-free/commit/43e365a0acba3aed2676e68795fce5338cc35541
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M htdocs/scss/skins/celerity.scss

Log Message:
-----------
Merge pull request #933 from afuna/bad-scrollbar-no-cookie

Get rid of horizontal scrollbar


Compare: https://github.com/dreamwidth/dw-free/compare/57dc35c11ce1...43e365a0acba
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-nonfree
Commit: 7b9af90fd67ccea197de032fd905d6f919ea80c1
https://github.com/dreamwidth/dw-nonfree/commit/7b9af90fd67ccea197de032fd905d6f919ea80c1
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M htdocs/scss/skins/tropo/_tropo-base.scss

Log Message:
-----------
Get rid of horizontal scrollbar

Reset negative margin to 0 (to avoid it stretching the page), and now
that we have whitespace to the right, we can set right: 0


Commit: 98ffbc0b25aaede2a06a1419aab1cab5319b0128
https://github.com/dreamwidth/dw-nonfree/commit/98ffbc0b25aaede2a06a1419aab1cab5319b0128
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-12 (Tue, 12 Aug 2014)

Changed paths:
M htdocs/scss/skins/tropo/_tropo-base.scss

Log Message:
-----------
Merge pull request #81 from afuna/bad-scrollbar-no-cookie

Get rid of horizontal scrollbar


Compare: https://github.com/dreamwidth/dw-nonfree/compare/cd9c8d4b659e...98ffbc0b25aa
github: shadowy octopus with the head of a robot, emblazoned with the Dreamwidth swirl (Default)
[personal profile] github posting in [site community profile] changelog
Branch: refs/heads/develop
Home: https://github.com/dreamwidth/dw-free
Commit: a1bf2722c05d30f3d1c807de9502e0356409bd3d
https://github.com/dreamwidth/dw-free/commit/a1bf2722c05d30f3d1c807de9502e0356409bd3d
Author: Afuna <fu@dreamwidth.org>
Date: 2014-08-11 (Mon, 11 Aug 2014)

Changed paths:
M cgi-bin/LJ/Entry.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/S2/EntryPage.pm
M cgi-bin/LJ/Web.pm
M htdocs/go.bml
M htdocs/manage/tracking/comments.bml
M htdocs/manage/tracking/entry.bml
M htdocs/poll/index.bml

Log Message:
-----------
Use style_opts instead of style_args in the entry url

We were using style_opts for hashes, style_args for a string;
$entry->url expects a hash but was using style_args as the option name.
So rename it to match convention elsewhere


Commit: 57dc35c11ce16e0e156868c4b1708d10deb2630d
https://github.com/dreamwidth/dw-free/commit/57dc35c11ce16e0e156868c4b1708d10deb2630d
Author: Afuna <afuna@users.noreply.github.com>
Date: 2014-08-11 (Mon, 11 Aug 2014)

Changed paths:
M cgi-bin/LJ/Entry.pm
M cgi-bin/LJ/S2.pm
M cgi-bin/LJ/S2/EntryPage.pm
M cgi-bin/LJ/Web.pm
M htdocs/go.bml
M htdocs/manage/tracking/comments.bml
M htdocs/manage/tracking/entry.bml
M htdocs/poll/index.bml

Log Message:
-----------
Merge pull request #930 from afuna/style_args-to-style_opts

Use style_opts instead of style_args in the entry url


Compare: https://github.com/dreamwidth/dw-free/compare/bc40b4808f4c...57dc35c11ce1

Profile

denise: Image: Me, facing away from camera, on top of the Castel Sant'Angelo in Rome (Default)Denise

June 2013

S M T W T F S
      1
2345678
910 1112131415
16171819202122
23242526 272829
30      

Page Summary

Style Credit

Expand Cut Tags

No cut tags
Page generated Aug. 21st, 2014 04:00 pm
Powered by Dreamwidth Studios